odin-bot-v2 icon indicating copy to clipboard operation
odin-bot-v2 copied to clipboard

All relevant commands: Replace hardcoded ID's with ID's from config.js where possible

Open Asartea opened this issue 1 year ago • 2 comments

Complete the following REQUIRED checkboxes:

  • [x] I have thoroughly read and understand The Odin Project Contributing Guide

  • [x] The title of this issue follows the command name: brief description of request format, e.g. /help: add optional @user parameter

The following checkbox is OPTIONAL:

  • [x] I would like to be assigned this issue to work on it

1. Description of the Feature Request: While a lot of channel/member ID's are already stored in config.js, they are usually still hardcoded in the reply strings. Changing them to instead import and interpolate them has 2 advantages: in the unlikely but possible event a channel gets deleted and recreated there is one source of truth to change, and more importantly <#${channels.FAQChannelId}> is a lot clearer to read at a glance than something like <#823266307293839401>

2. Acceptance Criteria:

  • [ ] All ID's which are currently not present are added to config.js
  • [ ] All reply strings use imported and interpolated strings where possible

Asartea avatar Jul 02 '24 20:07 Asartea