coveralls-python icon indicating copy to clipboard operation
coveralls-python copied to clipboard

Fixed HTTP 422 for Github Actions; Improved/added log output

Open andy-maier opened this issue 2 years ago • 1 comments
trafficstars

This PR solved the issue for our repos. It is ready for review and merge. For details, see the commit message.

Note that the description that I added, of how coveralls.io treats the request parameters, is based on experiments. An official confirmation e.g. via discussion of https://github.com/lemurheavy/coveralls-public/issues/1710 is still pending.

Note that this PR does not change the default service name of "github-actions", and I still needed to set the service to "github", either with the --service=github option or with the COVERALLS_SERVICE_NAME: "github" env var. The question of whether to use service name "github" or "github-actions" is still a bit open I guess. My personal experience is that it always requires "github", but the comment in the code says that "github-actions" was more common.

Note that it is possible for coveralls users to address the issue without this PR, as I described in #252. Nevertheless, I think the issue should be solved in coveralls.

andy-maier avatar Apr 30 '23 16:04 andy-maier

I think this PR only fails due to the current failures on Python 3.5 and 3.6 (issue #374).

andy-maier avatar Apr 30 '23 17:04 andy-maier

@andy-maier thank you for going down the GHA rabbithole and figuring this all out. I've just read through this PR, the linked coveralls-public details, etc and done some testing. I think this is the right track (setting both values the same), as is using github instead of github-actions by default and avoiding the retry-on-422. I've created #427 with those changes as well as yours here merged together, and plan to merge and deploy it shortly as a new major version.

I did notice that despite the job_id == number you have in this PR, in the successful config you've got referenced by the coveralls-public issue, you're doing something different. Could you comment on that? I'm wondering if that's a default we should adopt?

Also curious on your change to add the omit value, what is that for?

TheKevJames avatar Apr 29 '24 14:04 TheKevJames