Tyler Stark

Results 14 comments of Tyler Stark
trafficstars

@lennerd What about: ``` javascript Model.prototype.reset = function(attrs, options) { for (var key in this.attributes) { this.unset(key, {silent:true}); } return this.set(attrs, options); }; ```

Cool, I get what you mean. I'd probably opt for using `this.unset(key, options)` over overriding this.attributes explicitly, but that's just a matter of swapping out `attrs[key] = void 0;` :panda_face:

@sceee Thank you for the bug report! This should be fixed with `[email protected]` with https://github.com/firebase/firebase-functions/pull/1151. Please let me know if you're seeing the issue given `[email protected]`. @mpsq Is this still...

Closing this pull request while I implement functionality in smaller chunks.

I can certainly take a look. Giving a heads up, it might be a minute while I sort through previous history.

@tettoffensive || @HugoGresse Do either of you have a repo that can reproduce this? I attempted for a while this morning but was not able to reproduce. Might be due...

@HugoGresse - It wasn't a PEBKAC issue until recently :) @tettoffensive - Digging deeper, it looks like this issue was introduced in https://github.com/googleapis/nodejs-firestore/pull/1570, when a bunch of `@internal` were added....

@trex-quo Thank you for the bug report! V2 Callable Function wrapping has not been implemented yet. Theres going to need to be some work to implement this. I've added the...