TheHive4py icon indicating copy to clipboard operation
TheHive4py copied to clipboard

"archive" parameter of download_observable_attachment is overriden

Open TytoCapensis opened this issue 4 years ago • 0 comments

Request Type

Bug

Work Environment

Question Answer
TheHive4py version / git hash Latest (a8ad708de93f51bd284e56e9c869c3d20da56938)

Problem Description

Function download_observable_attachment is calling download_attachment, but the archive parameter will be always True regardless of what was specified in download_observable_attachment call

Steps to Reproduce

  1. Call download_observable_attachment with archive=False as a parameter
  2. Notice that the file output is not readable when you expect a text file
  3. Notice that it works when you directly use download_attachment with archive=False

Possible Solutions

In file api.py on line 1299, replace archive=True by archive

TytoCapensis avatar Jan 26 '21 09:01 TytoCapensis