Thyme icon indicating copy to clipboard operation
Thyme copied to clipboard

Fix diagonal movement speed bug

Open xezon opened this issue 3 years ago • 4 comments

This change fixes the diagonal movement speed bug.

Reference https://github.com/TheSuperHackers/GeneralsGameCode/issues/123

Demo

https://user-images.githubusercontent.com/4720891/193651852-ba618719-c85c-4b9b-8ad4-7058da911af4.mp4

xezon avatar Oct 03 '22 18:10 xezon

I suggest to merge this fix later when we no longer need game state to be consistent with original. For now it will be good to have Thyme work similar to Original, so we can use Original Replays to backtest and find issues. This change would break this ability.

xezon avatar Oct 03 '22 19:10 xezon

Fix is done, but converting to Draft for the time being.

xezon avatar Oct 04 '22 07:10 xezon

Functions were moved from header to cpp file. Change updated accordingly.

xezon avatar Oct 18 '22 19:10 xezon

Codecov Report

Patch and project coverage have no change.

Comparison is base (e1609b2) 2.67% compared to head (4b6826b) 2.67%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop    TheSuperHackers/GeneralsGamePatch#752   +/-   ##
=======================================
  Coverage     2.67%   2.67%           
=======================================
  Files          822     822           
  Lines        89290   89294    +4     
  Branches     14799   14799           
=======================================
+ Hits          2387    2390    +3     
- Misses       86559   86560    +1     
  Partials       344     344           
Files Changed Coverage Δ
src/game/logic/object/update/physicsupdate.cpp 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 09 '23 19:08 codecov-commenter