Jimmy Byrd
Jimmy Byrd
👋 While I wouldn't depend on `FSharp.Control.TaskSeq` for this, I'd accept a PR for handling `IAsyncEnumerable`. Here's an example of the [implementation in IcedTasks](https://github.com/TheAngryByrd/IcedTasks/blob/db0b55bd89f769e17744319bfc510486a5b1fc5f/src/IcedTasks/TaskBuilderBase.fs#L343-L357) someone could use for reference.
Since `ArgsType` seems to be record with string array: https://github.com/dotnet-websharper/core/blob/35c354b583b6046c75865f7f33d9bf08919ad5af/src/compiler/WebSharper.Compiler/WsFscServiceCommon.fs#L6 Replacing [BinaryFormatter](https://github.com/search?q=repo%3Adotnet-websharper%2Fcore%20binaryformatter&type=code) calls it with something like [System.Text.Json](https://learn.microsoft.com/en-us/dotnet/api/system.text.json?view=net-8.0) should be fairly straight forward.
Is there a specific exception coming through for `WorkspaceLoaderProjectGraph` test? I know ProjectGraph can [throw exceptions if another "build" is in progress](https://learn.microsoft.com/en-us/dotnet/api/microsoft.build.execution.buildmanager.beginbuild?view=msbuild-17-netcore#microsoft-build-execution-buildmanager-beginbuild(microsoft-build-execution-buildparameters)).
I agree this would be very nice to have but I think something like this should live in `FSharp.Compiler.Service`. If it's possible to prototype in `FsAutocomplete`, I'm for it but...
I think it's all the backing needed for it, like getting aliases of aliases and such. Like there's a bug about them: https://github.com/ionide/ionide-vscode-fsharp/issues/1947
I decided to add them in [IcedTasks](https://github.com/TheAngryByrd/IcedTasks/pull/24) under `AsyncEx` if anyone wants to give it a try.
> Ran into the same issue, I fixed it by adding a unique id on the docId config, looks like it happens when two editors have the same config. This...
Overall love it :) Probably needs some extra tests to make sure we don't mess up files or regress.
> Can you give any particular advice? @florenzen has an example here that would be useful as a test case.
> This should've been fixed in FCS already @vzarytovskii was this released in a nuget package yet?