Jimmy Byrd

Results 256 comments of Jimmy Byrd

We get some disappointing first generated `launch.json`. ```json { // Use IntelliSense to learn about possible attributes. // Hover to view descriptions of existing attributes. // For more information, visit:...

Also trying to run a project from the Solution Explorer fails: https://github.com/ionide/ionide-vscode-fsharp/assets/1490044/33257a3f-f4a8-42c6-b832-bc3af99d349e Where it does seem to work in the current version.

Wonder if there's gonna be complications with https://github.com/ionide/ionide-vscode-fsharp/pull/1927/

Looks good, ~~putting it in the [Adapters](https://github.com/TheAngryByrd/FsLibLog/tree/master/adapters) would be where it should end up.~~ Technically this is a [Provider](https://github.com/TheAngryByrd/FsLibLog/blob/master/src/FsLibLog/FsLibLog.fs#L411) so maybe we should consider adding a separate folder similar to...

for [v5](https://github.com/demystifyfp/FsToolkit.ErrorHandling/pull/249) of FsToolkit.ErrorHandling i'm removing Ply as a dependency and requiring F# 6 Core as a minimum. Because of that, I'm re-evaluating moving all the task code into the...

> I am in favor of setting .NET 6 as the minimum target runtime. 🎉 To clarify, that is not what I'm doing (I know this gets confusing). I'm setting...

@bartelink I did create an “asyncEx” in IcedTasks with the unwrapping aggregate semantics. Could you give that a once over and make sure it’s working the way you think it...

I looked into this over Christmas and it seems to be the case that is isn't simple because [ReturnFrom](https://github.com/dotnet/fsharp/blob/0ce1337c2e90093f41e50d4e49b2718da29de7bc/tests/benchmarks/CompiledCodeBenchmarks/TaskPerf/TaskPerf/async2.fs#L286) doesn't know if we're coming from our own state machine builder...

Also take a look over and use anything from [IcedTasks ValueTask](https://github.com/TheAngryByrd/IcedTasks/blob/master/src/IcedTasks/ValueTasks.fs) and the [corresponding tests]( https://github.com/TheAngryByrd/IcedTasks/blob/master/tests/IcedTasks.Tests/ValueTaskTests.fs)

Well I just ended up following a thread https://github.com/dotnet/roslyn/pull/19146#discussion_r114613742 that talks about how to make sure that `ReferencePathWithRefAssemblies` is not empty. Adding `FindReferenceAssembliesForReferences` to ProjInfo seems to work. Given that...