Rust icon indicating copy to clipboard operation
Rust copied to clipboard

Update closest_points.rs

Open syed-ghufran-hassan opened this issue 7 months ago • 1 comments

Adding edge case for large dataset.

Pull Request Template

Description

Please include a summary of the change and which issue (if any) is fixed. A brief description of the algorithm and your implementation method can be helpful too. If the implemented method/algorithm is not so well-known, it would be helpful to add a link to an article explaining it with more details.

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ ] I ran bellow commands using the latest version of rust nightly.
  • [ ] I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • [ ] I ran cargo fmt just before my last commit.
  • [ ] I ran cargo test just before my last commit and all tests passed.
  • [ ] I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • [ ] I added my algorithm to DIRECTORY.md with the correct link.
  • [ ] I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or try to optimize your code or make the test easier to run. We have this rule because we have hundreds of tests to run; If each one of them took 300ms, we would have to wait for a long time.

syed-ghufran-hassan avatar Apr 23 '25 16:04 syed-ghufran-hassan

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.49%. Comparing base (a45a382) to head (2bf3d8a). Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
src/geometry/closest_points.rs 83.33% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #878      +/-   ##
==========================================
- Coverage   95.50%   95.49%   -0.01%     
==========================================
  Files         317      317              
  Lines       22948    22960      +12     
==========================================
+ Hits        21916    21926      +10     
- Misses       1032     1034       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Apr 23 '25 16:04 codecov-commenter

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 17 '25 00:07 github-actions[bot]

@syed-ghufran-hassan: could you please explain what value does this test case add? In other words: what is the new situation, which it covers?

This needs to be added because the algorithm does not cover large datasets, high precision and floating points comparison in range

syed-ghufran-hassan avatar Jul 17 '25 07:07 syed-ghufran-hassan

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 17 '25 00:08 github-actions[bot]

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel. Thank you for your contributions!

github-actions[bot] avatar Aug 25 '25 00:08 github-actions[bot]