Rust
Rust copied to clipboard
Addition of multiple_longest_common_subsequence
Description
To whom it may concern,
this pull request aims at introducing an algorithm to find the longest common subsequence among multiple sequences.
Finding a solution other than brute force is not really intuitive. I advise to look at the first comments of this thread.
The pull request implements a method based on heuristic, as described in the following research paper.
Thank you for considering this work.
Type of change
- [X] New feature (non-breaking change which adds functionality)
Checklist:
- [X] I ran bellow commands using the latest version of rust nightly.
- [X] I ran
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found. Note: I mean I did only delete the issues related to my pull request - [X] I ran
cargo fmtjust before my last commit. - [X] I ran
cargo testjust before my last commit and all tests passed. - [X] I added my algorithm to the corresponding
mod.rsfile within its own folder, and in any parent folder(s). - [X] I added my algorithm to
DIRECTORY.mdwith the correct link. - [X] I checked
COUNTRIBUTING.mdand my code follows its guidelines.
Codecov Report
Attention: Patch coverage is 99.53052% with 1 line in your changes missing coverage. Please review.
Project coverage is 95.53%. Comparing base (
b4aecf4) to head (b355c68). Report is 3 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/string/multiple_longest_common_subsequence.rs | 99.53% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #861 +/- ##
==========================================
+ Coverage 95.49% 95.53% +0.04%
==========================================
Files 316 318 +2
Lines 22919 23161 +242
==========================================
+ Hits 21887 22128 +241
- Misses 1032 1033 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Hello,
I might need help with this pull request, especially cargo clippy --all -- -D warnings.
Surely I am not supposed to fix the 500+ errors already present before, right ?
I tried to run cargo clippy --fix but it wouldn't do.
Thank you
Hello,
I might need help with this pull request, especially
cargo clippy --all -- -D warnings.Surely I am not supposed to fix the 500+ errors already present before, right ? I tried to run
cargo clippy --fixbut it wouldn't do.Thank you
@Gaspardcode: Try updating your branch. There were some new warnings introduced, but it should work now (cf. #871).
Hello, I might need help with this pull request, especially
cargo clippy --all -- -D warnings. Surely I am not supposed to fix the 500+ errors already present before, right ? I tried to runcargo clippy --fixbut it wouldn't do. Thank you@Gaspardcode: Try updating your branch. There were some new warnings introduced, but it should work now (cf. #871).
Hello, I did indeed fixed it by simply pulling, thank you
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel. Thank you for your contributions!