Rust icon indicating copy to clipboard operation
Rust copied to clipboard

Added is_valid_email_address.rs

Open uncertaain opened this issue 1 year ago • 4 comments

Changes

  • add is_valid_email_address.rs

Type of change

  • [x] New feature (non-breaking change which adds functionality)

Checklist:

  • [x] I ran bellow commands using the latest version of rust nightly.
  • [x] I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • [x] I ran cargo fmt just before my last commit.
  • [x] I ran cargo test just before my last commit and all tests passed.
  • [x] I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • [x] I added my algorithm to DIRECTORY.md with the correct link.
  • [x] I checked COUNTRIBUTING.md and my code follows its guidelines.

uncertaain avatar Aug 26 '24 11:08 uncertaain

Codecov Report

Attention: Patch coverage is 96.95122% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.34%. Comparing base (b2acfd2) to head (5460340). Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/string/is_valid_email_address.rs 96.95% 5 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
+ Coverage   95.33%   95.34%   +0.01%     
==========================================
  Files         310      311       +1     
  Lines       22657    22821     +164     
==========================================
+ Hits        21600    21759     +159     
- Misses       1057     1062       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 26 '24 11:08 codecov-commenter

I handled all the things that you requested.

uncertaain avatar Sep 08 '24 19:09 uncertaain

Please make sure to update your branch (cf. #789) - otherwise the CI will fail.

vil02 avatar Sep 13 '24 19:09 vil02

I think I fixed all the issues and made the IP checking better.

uncertaain avatar Sep 14 '24 11:09 uncertaain

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 04 '24 00:11 github-actions[bot]

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel. Thank you for your contributions!

github-actions[bot] avatar Nov 12 '24 00:11 github-actions[bot]