Rust
Rust copied to clipboard
typing errors, extra tests
Pull Request Template
Description
Just added some extra tests and used typiing for some errors. Might do some more soon.
Type of change
Please delete options that are not relevant.
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist:
- [ ] I ran bellow commands using the latest version of rust nightly.
- [ ] I ran
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found. - [ ] I ran
cargo fmtjust before my last commit. - [ ] I ran
cargo testjust before my last commit and all tests passed. - [ ] I added my algorithm to the corresponding
mod.rsfile within its own folder, and in any parent folder(s). - [ ] I added my algorithm to
DIRECTORY.mdwith the correct link. - [ ] I checked
COUNTRIBUTING.mdand my code follows its guidelines.
Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.
Codecov Report
Attention: Patch coverage is 86.95652% with 6 lines in your changes are missing coverage. Please review.
Project coverage is 94.77%. Comparing base (
20c92d7) to head (4be9f49).
| Files | Patch % | Lines |
|---|---|---|
| src/data_structures/queue.rs | 80.00% | 3 Missing :warning: |
| src/data_structures/range_minimum_query.rs | 40.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #709 +/- ##
==========================================
- Coverage 94.78% 94.77% -0.02%
==========================================
Files 297 297
Lines 22149 22182 +33
==========================================
+ Hits 20994 21023 +29
- Misses 1155 1159 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
in draft mode, just doing this for fun and will get back but got a bunch of things I need to run to first