Python icon indicating copy to clipboard operation
Python copied to clipboard

Rewrite queue to make it more meaningful and readable, add type hints…

Open king-phyte opened this issue 4 years ago • 6 comments

Describe your change:

  • Replaced previous definition of the Queue class with a more readable one

  • Added more meaningful functions

  • Added type hints

  • Added doctests to the class

  • [x] Add an algorithm?

  • [ ] Fix a bug or typo in an existing algorithm?

  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

king-phyte avatar Nov 06 '21 00:11 king-phyte

Please I see the PR hasn't been merged. Are there any reasons why? Anything you'd like me to add or modify?

king-phyte avatar Dec 02 '21 14:12 king-phyte

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 19 '22 00:04 stale[bot]

@IdoErel mind approving?

enedil avatar May 12 '22 21:05 enedil

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 12 '22 20:06 stale[bot]

Mr stale bot, please don't be so obnoxious.

enedil avatar Jun 15 '22 10:06 enedil

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 31 '22 08:07 stale[bot]

Screw you, Mr stale bot

enedil avatar Aug 01 '22 12:08 enedil

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

stale[bot] avatar Aug 14 '22 03:08 stale[bot]

Screw you, Mr stale bot

enedil avatar Aug 14 '22 16:08 enedil