JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

docs: fixed misleading comment about the array method (forEach instead of reduce) used in AverageMean.js

Open HRIDYANSHU054 opened this issue 1 year ago • 4 comments

Open in Gitpod know more

Describe your change:

  • [x] Documentation change? what was wrong? wrong array method in comment

Before:

// This loop sums all values in the 'nums' array using forEach loop
const sum = nums.reduce((sum, cur) => sum + cur, 0)

After:

// This calculates the sum of all values in the 'nums' array using reduce method.  
const sum = nums.reduce((sum, cur) => sum + cur, 0)

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new JavaScript files are placed inside an existing directory.
  • [x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

HRIDYANSHU054 avatar Oct 10 '24 13:10 HRIDYANSHU054

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.76%. Comparing base (ff314a2) to head (d0e1ba9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1727      +/-   ##
==========================================
- Coverage   84.76%   84.76%   -0.01%     
==========================================
  Files         378      378              
  Lines       19742    19738       -4     
  Branches     2955     2957       +2     
==========================================
- Hits        16735    16731       -4     
  Misses       3007     3007              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 10 '24 13:10 codecov-commenter

Just remove the comment. It adds no value.

appgurueu avatar Oct 10 '24 13:10 appgurueu

@appgurueu Done.

HRIDYANSHU054 avatar Oct 10 '24 14:10 HRIDYANSHU054

@raklaptudirm please review the changes

HRIDYANSHU054 avatar Oct 10 '24 16:10 HRIDYANSHU054