JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

Fixes #1666: Remove duplicate entry of Sieve of Eratosthenes

Open ApeSkillx opened this issue 1 year ago • 1 comments

Fixes Issue #1666

  • Removed the SieveOfEratosthenes.js file, which contained the boolean array implementation.
  • Renamed SieveOfEratosthenesIntArray.js to SieveOfEratosthenes.js to maintain a cleaner and clearer implementation.
  • Consolidated and updated the tests to reflect the changes.

All tests pass locally.

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new JavaScript files are placed inside an existing directory.
  • [x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [ ] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

ApeSkillx avatar Oct 05 '24 05:10 ApeSkillx