JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

test: add tests for Eucledian GCD Algorithm

Open malpotra opened this issue 2 years ago • 1 comments

Open in Gitpod know more

Describe your change:

  • [ ] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [ ] I have read CONTRIBUTING.md.
  • [ ] This pull request is all my own work -- I have not plagiarized.
  • [ ] I know that pull requests will not be merged if they fail the automated tests.
  • [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ ] All new JavaScript files are placed inside an existing directory.
  • [ ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [ ] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

malpotra avatar Oct 14 '23 15:10 malpotra

As said, I think the existing GCD tests should be reused (or the recursive function should be removed altogether, as it is strictly inferior).

appgurueu avatar Oct 20 '23 17:10 appgurueu