JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

Longest Palindromic Substring

Open ZainabMalik5 opened this issue 2 years ago • 5 comments

Open in Gitpod know more

Describe your change:

I have added JavaScript code for finding longest palindromic substring using dynamic programming

  • [x ] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x ] I have read CONTRIBUTING.md.
  • [x ] This pull request is all my own work -- I have not plagiarized.
  • [x ] I know that pull requests will not be merged if they fail the automated tests.
  • [x ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x ] All new JavaScript files are placed inside an existing directory.
  • [x ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [x ] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [x ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

ZainabMalik5 avatar Oct 09 '23 09:10 ZainabMalik5

Is it working fine or I need to make some changes?

ZainabMalik5 avatar Oct 09 '23 15:10 ZainabMalik5

Added JSDoc Comments but could not find more suitable variable names.

ZainabMalik5 avatar Oct 09 '23 17:10 ZainabMalik5

Please review my PR.

ZainabMalik5 avatar Oct 10 '23 04:10 ZainabMalik5

Please review and test it.

ZainabMalik5 avatar Oct 10 '23 07:10 ZainabMalik5

The only point of my review you seem to have addressed yet is the addition of a JSDoc comment.

appgurueu avatar Oct 10 '23 15:10 appgurueu