JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

Published 20 hours ago • verified publisher icon TheAlgorithms

Divisors.js

Open ZainabMalik5 opened this issue 2 years ago • 4 comments

I have added a file for computing all unique divisors of a number in javascript in Maths folder. Please merge my PR.

ZainabMalik5 avatar Oct 04 '23 18:10 ZainabMalik5

I have made the necessary changes and sent you a pull request. Please merge it.

On Thu, Oct 5, 2023 at 1:43 PM Gaurav Giri @.***> wrote:

@.**** requested changes on this pull request.

The algorithm implementation looks good to me. However, there are few suggestions I would like to provide:

  1. The function name is printDivisors(), but it doesn't prints anything, just returns a list of divisors. I suggest to change it to something like getDivisors().
  2. Change variable name into something meaningful .
  3. Also add documentations comment.

— Reply to this email directly, view it on GitHub https://github.com/TheAlgorithms/JavaScript/pull/1435#pullrequestreview-1659178439, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWWATJMLHEVSVWCTYGMGHFLX5ZT3NAVCNFSM6AAAAAA5TCI7SGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJZGE3TQNBTHE . You are receiving this because you authored the thread.Message ID: @.***>

ZainabMalik5 avatar Oct 07 '23 09:10 ZainabMalik5

Please merge PR #1435 if it's fine.

ZainabMalik5 avatar Oct 08 '23 10:10 ZainabMalik5

I have made the necessary changes in Divisors.js. Please review it.

ZainabMalik5 avatar Oct 09 '23 11:10 ZainabMalik5

I have made the necessary changes in Divisors.js. Please review it.

It's still missing tests.

appgurueu avatar Oct 09 '23 13:10 appgurueu