JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

Added Miller Rabin Primality Test

Open sundaram123krishnan opened this issue 2 years ago • 8 comments

Open in Gitpod know more

Describe your change:

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new JavaScript files are placed inside an existing directory.
  • [x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

sundaram123krishnan avatar May 04 '23 16:05 sundaram123krishnan

someone help with indentation pls , thx in advance

sundaram123krishnan avatar May 04 '23 17:05 sundaram123krishnan

someone help with indentation pls , thx in advance

You should be able to simply run https://standardjs.com/ against your code.

appgurueu avatar May 04 '23 18:05 appgurueu

yaa actually i had added npm format package

sundaram123krishnan avatar May 05 '23 07:05 sundaram123krishnan

now it works, thx

sundaram123krishnan avatar May 05 '23 07:05 sundaram123krishnan

deleted

sundaram123krishnan avatar May 05 '23 10:05 sundaram123krishnan

any further changes to be done ? @appgurueu

sundaram123krishnan avatar May 06 '23 09:05 sundaram123krishnan

should i add more comments explaining this algorithm?

sundaram123krishnan avatar May 06 '23 16:05 sundaram123krishnan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 18 '23 07:06 stale[bot]