JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

Slid wind

Open Ramzi-Abidi opened this issue 2 years ago • 4 comments

Open in Gitpod know more

Describe your change:

  • [ Add ] Adding sliding window algo(fruitsIntoBasket)

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new JavaScript files are placed inside an existing directory.
  • [x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Ramzi-Abidi avatar Feb 14 '23 16:02 Ramzi-Abidi

Please add comments and more test cases.

Done :))

Ramzi-Abidi avatar Feb 14 '23 21:02 Ramzi-Abidi

Sorry, I should've clarified: I meant comments on the implementation, not extending the doc comment; the doc comment was already good enough, the further additions were not necessary.

As for the tests: Please refer to https://github.com/TheAlgorithms/TypeScript/blob/master/CONTRIBUTING.md#writing-good-tests.

appgurueu avatar Feb 15 '23 09:02 appgurueu

Sorry, I should've clarified: I meant comments on the implementation, not extending the doc comment; the doc comment was already good enough, the further additions were not necessary.

As for the tests: Please refer to https://github.com/TheAlgorithms/TypeScript/blob/master/CONTRIBUTING.md#writing-good-tests.

Ramzi-Abidi avatar Feb 16 '23 21:02 Ramzi-Abidi

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 18 '23 07:06 stale[bot]