JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

Published 20 hours ago • verified publisher icon TheAlgorithms

[BUG] `DIRECTORY.md` workflow not running due to protected branch

Open Panquesito7 opened this issue 3 years ago • 10 comments

Description

The DIRECTORY.md workflow isn't committing/pushing any needed changes due to the master branch being protected. Currently, there's no way to make GitHub Actions have access to a protected branch.

Our current options are:

  • Disable branch protection (not recommended).
  • Commit as someone with access to making direct commits to the branch.
  • Wait until GitHub provides a solution to this.

Panquesito7 avatar Oct 21 '22 02:10 Panquesito7

Directory.md is currently changed in the prs themselves which I think is good enough.

raklaptudirm avatar Oct 21 '22 11:10 raklaptudirm

Directory.md is currently changed in the prs themselves which I think is good enough.

Yeah. Although, I still think this should be kept open until GitHub actually fixes this.

Panquesito7 avatar Oct 21 '22 17:10 Panquesito7

The ideal scenario would be for the workflow to run only in the master.

raklaptudirm avatar Oct 22 '22 04:10 raklaptudirm

The ideal scenario would be for the workflow to run only in the master.

That currently won't work as the master branch is protected.

Panquesito7 avatar Oct 23 '22 00:10 Panquesito7

Maintainer / Owner access is never able to force push again for default & protected branch,

isaacudofia avatar Nov 01 '22 19:11 isaacudofia

Description

The DIRECTORY.md workflow isn't committing/pushing any needed changes due to the master branch being protected. Currently, there's no way to make GitHub Actions have access to a protected branch.

Our current options are:

  • Disable branch protection (not recommended).
  • Commit as someone with access to making direct commits to the branch.
  • Wait until GitHub provides a solution to this.

rickydoo680 avatar Dec 29 '23 02:12 rickydoo680

@raklaptudirm, should I change the workflow to create a PR to the repository, just like in other repositories such as C/C++?

Panquesito7 avatar Jan 15 '24 20:01 Panquesito7

@raklaptudirm, should I change the workflow to create a PR to the repository, just like in other repositories such as C/C++?

That would be best imo.

raklaptudirm avatar Jan 16 '24 07:01 raklaptudirm

If anyone wants to work on this, feel free to create a PR. 🙂

Panquesito7 avatar Apr 11 '24 03:04 Panquesito7

I can Check on this

SharmilaChandariah avatar Apr 27 '24 22:04 SharmilaChandariah