Java icon indicating copy to clipboard operation
Java copied to clipboard

feat: Add Xs3Conversion algo with JUnit tests

Open Tanmay-Singh3004 opened this issue 1 year ago • 1 comments

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized it.
  • [x] All filenames are in PascalCase.
  • [x] All functions and variable names follow Java naming conventions.
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • [x] All new code is formatted with clang-format -i --style=file path/to/your/file.java

Tanmay-Singh3004 avatar Oct 12 '24 21:10 Tanmay-Singh3004

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.01%. Comparing base (6682c7c) to head (4897c67).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5743      +/-   ##
============================================
+ Coverage     63.96%   64.01%   +0.05%     
- Complexity     4172     4176       +4     
============================================
  Files           583      584       +1     
  Lines         16320    16338      +18     
  Branches       3150     3152       +2     
============================================
+ Hits          10439    10459      +20     
+ Misses         5456     5455       -1     
+ Partials        425      424       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 12 '24 21:10 codecov-commenter

@siriak , Thanks ! I first thought of adding this to the BcdConversion.java file, since the conversion to Excess-3 is almost similar to the Bcd conversion algorithm.

Tanmay-Singh3004 avatar Oct 13 '24 07:10 Tanmay-Singh3004