Java icon indicating copy to clipboard operation
Java copied to clipboard

updated CreateAndDetectLoop with test

Open albinsabu2023 opened this issue 1 year ago • 3 comments

Above algorithm helps to find the length of loop in linkedlist

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized it.
  • [x] All filenames are in PascalCase.
  • [x] All functions and variable names follow Java naming conventions.
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • [x] All new code is formatted with clang-format -i --style=file path/to/your/file.java

albinsabu2023 avatar Oct 03 '24 20:10 albinsabu2023

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.80%. Comparing base (b54cc21) to head (688b48b).

Files with missing lines Patch % Lines
...thms/datastructures/lists/CreateAndDetectLoop.java 84.21% 1 Missing and 2 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5561      +/-   ##
============================================
+ Coverage     58.59%   58.80%   +0.20%     
- Complexity     3749     3759      +10     
============================================
  Files           554      554              
  Lines         15922    15908      -14     
  Branches       3030     3028       -2     
============================================
+ Hits           9330     9354      +24     
+ Misses         6195     6154      -41     
- Partials        397      400       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 03 '24 20:10 codecov-commenter

It's already present here https://github.com/TheAlgorithms/Java/blob/b61c54797babbe46825586894d69715d8947d559/src/main/java/com/thealgorithms/datastructures/lists/CreateAndDetectLoop.java#L5. Please improve the existing implementation (remove main, add tests, etc.)

siriak avatar Oct 04 '24 17:10 siriak

Am i missing something ? Cuz I didnt get any response @arindam89 @siriak @BurkHufnagel

albinsabu2023 avatar Oct 07 '24 16:10 albinsabu2023