Java icon indicating copy to clipboard operation
Java copied to clipboard

Enhance readability, add comments & function docs to SkylineProblem.java

Open Hardvan opened this issue 1 year ago • 2 comments

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized it.
  • [x] All filenames are in PascalCase.
  • [x] All functions and variable names follow Java naming conventions.
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • [x] All new code is formatted with clang-format -i --style=file path/to/your/file.java

Hardvan avatar Oct 03 '24 04:10 Hardvan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.96%. Comparing base (f34fe4d) to head (0f6001a).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5534      +/-   ##
============================================
+ Coverage     54.56%   54.96%   +0.40%     
- Complexity     3413     3426      +13     
============================================
  Files           535      535              
  Lines         15383    15362      -21     
  Branches       2935     2932       -3     
============================================
+ Hits           8393     8443      +50     
+ Misses         6637     6564      -73     
- Partials        353      355       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 03 '24 04:10 codecov-commenter

I have removed the print and main methods along with the addition of Junit tests.

Hardvan avatar Oct 05 '24 14:10 Hardvan