Java icon indicating copy to clipboard operation
Java copied to clipboard

Implemented Fast Inverse Sqrt Method

Open dougcodez opened this issue 3 years ago • 2 comments
trafficstars

Describe your change:

  • [x ] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

References

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x ] This pull request is all my own work -- I have not plagiarized.
  • [x ] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ x] All new Java files are placed inside an existing directory.
  • [x ] All filenames are in all uppercase characters with no spaces or dashes.
  • [ x] All functions and variable names follow Java naming conventions.
  • [ x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

dougcodez avatar Jul 23 '22 12:07 dougcodez

The code looks good, could you add some automated tests as well?

I have just pushed my latest commit that consists of automated tests between both methods

dougcodez avatar Jul 24 '22 15:07 dougcodez

Take a look at the files here https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms, main is an entry point and won't be run by a testing framework. It would help if you had JUnit tests https://www.vogella.com/tutorials/JUnit/article.html

siriak avatar Jul 25 '22 06:07 siriak

Can I work under this issue?

siddhant2002 avatar Aug 18 '22 15:08 siddhant2002

@siriak Please check the pr

siddhant2002 avatar Aug 22 '22 07:08 siddhant2002

@siddhant2002 which PR?

siriak avatar Aug 23 '22 18:08 siriak