Java Preorder traversal in RedBlackBST is incorrect

Preorder traversal in RedBlackBST is incorrect

Open Golden-Pigeon opened this issue 3 years ago • 7 comments

trafficstars

In the class com.thealgorithms.datastructures.trees.RedBlackBST, the preorder traversal is

public void printTreepre(Node node) {
    if (node == nil) {
        return;
    }
    System.out.print(
         ((node.color == R) ? " R " : " B ") + "Key: " + node.key + " Parent: " + node.p.key + "\n");
    printTree(node.left);
    printTree(node.right);
}

Should the last two lines call printTreepre rather than printTree? printTree is an inorder traversal method.

May 05 '22 08:05 Golden-Pigeon

Instead of printTreepre use printTree the error occured you assigned the wrong thing

May 06 '22 09:05 Commanderadi

I think it should call printTreepre at the end of the function

May 06 '22 17:05 siriak

I think it should call printTreepre at the end of the function

Yes, that is what I mean.

May 07 '22 15:05 Golden-Pigeon

public void printTreepre(Node node) { if (node == nil) { return; } System.out.print( ((node.color == R) ? " R " : " B ") + "Key: " + node.key + " Parent: " + node.p.key + "\n"); return printTreepre(node.left)+ printTreepree(node.right);

}