Algorithms-Explanation icon indicating copy to clipboard operation
Algorithms-Explanation copied to clipboard

Published 20 hours ago • verified publisher icon TheAlgorithms

[BUG]: Broken GitHub links that point to implementations

Open Panquesito7 opened this issue 4 years ago • 9 comments

This issue was found thanks to @siriak that reported it in https://github.com/TheAlgorithms/website/issues/142. Anyone who wants to work on it, feel free to let us know below, and we'll assign you! 🙂

Panquesito7 avatar Nov 24 '21 20:11 Panquesito7

Hey, I have created a pull-request fixing this issue.

itsmohitmkk avatar Dec 03 '21 17:12 itsmohitmkk

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jan 03 '22 00:01 github-actions[bot]

is this issue still valid?

sambhavsaxena avatar Jan 27 '22 13:01 sambhavsaxena

is this issue still valid?

Yep, it's still valid. 🙂

Panquesito7 avatar Jan 27 '22 15:01 Panquesito7

Has the links been replaced?

ahmedsaheed avatar Mar 21 '22 22:03 ahmedsaheed

Hi @Panquesito7, I think I fixed all the links that were broken except one which is "https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/selecting/quickSelect.cpp", I didn't find the location of the file. But the real problem... there are more than 100 links!😲 , I don't know if you still want the PR to be done, and if so, do you want all the changes to be uploaded in a single PR?

alaanescobedo avatar Apr 24 '22 21:04 alaanescobedo

Hey there! A single PR should be fine, as long as it's for the same repository (in this case, C++). Sorry for the very late reply. Thanks for your interest in contributing. 🙂

Panquesito7 avatar Feb 10 '23 21:02 Panquesito7

This issue was found thanks to @siriak that reported it in TheAlgorithms/website#142. Anyone who wants to work on it, feel free to let us know below, and we'll assign you! 🙂

Do you mean we need ti change the links to the algorithem website?

lukasb1b avatar Sep 04 '23 20:09 lukasb1b

This issue was found thanks to @siriak that reported it in TheAlgorithms/website#142. Anyone who wants to work on it, feel free to let us know below, and we'll assign you! 🙂

Do you mean we need ti change the links to the algorithem website?

To be honest, we should consider getting rid of the links entirely. On the website, they are redundant. If people choose to browse on GitHub, they can find the implementations by searching on the website; a single website link in the readme suffices for that. If we do want to add these links for convenience, a single link to the appropriate algorithm page on the website should be used (rather than links for all languages).

appgurueu avatar Sep 14 '23 11:09 appgurueu