web-ifc-three icon indicating copy to clipboard operation
web-ifc-three copied to clipboard

No way to use web-ifc-three with latest threejs version or any version other then 0.135.0

Open brutestack opened this issue 3 years ago • 2 comments

Since this commit 852970e1137c9b1bdf189b4fe7deaf785408d47f there is no way to use web-ifc-three with any version of threejs other then 0.135.0 because of exact version match requirement in peerDependencies part of package.json image

Is it really important for web-ifc-three to be used exactly with threejs version 0.135.0?

brutestack avatar Jul 11 '22 21:07 brutestack

You can build the package on your local machine and update dependency to Three.js version you need and use it in your project. I have tested it and it did work.

HassanEmam avatar Jul 21 '22 20:07 HassanEmam

@brutestack there is always a way ;)

makc avatar Jul 22 '22 15:07 makc

@brutestack, I hope the fix by @makc worked. Let us know if it still does not work.

aka-blackboots avatar Nov 28 '22 11:11 aka-blackboots

@aka-blackboots , @makc thank you for your work. Unfortunately, web-ifc-three version 0.0.121 still has this issue.

Doing npm i gives me the following: image

I have the following dependencies in my project: image

The only way for me to get through this with latest versions of three and web-ifc-three is adding overrides section to my package.json like this (as @makc adviced):

"overrides": {
    "three": "0.146.0"
  },

brutestack avatar Nov 28 '22 18:11 brutestack

Hey, I just published a new version that uses 0.149.0! If neither this nor the solutions above solve your issue, let us know. Otherwise, we'll close this issue.

agviegas avatar Mar 25 '23 11:03 agviegas

This is still an issue, and the problem is that ThreeJS versions start at 0.X.X. It's probably better to just remove three as a peerDepedency until ThreeJS decides to increment the Major.

DoisKoh avatar May 10 '23 09:05 DoisKoh

until ThreeJS decides to increment the Major

which is likely never

makc avatar May 12 '23 21:05 makc

@DoisKoh how would you like to find the dependency in the library? 🤔

agviegas avatar May 15 '23 11:05 agviegas

Unfortunately I can't think of a solution outside of stating clearly in the documentation what version of ThreeJS is supported - as it stands right now, without manually modifying the package-lock.json, we can't install web-ifc-three due to the conflict in the peerDepedency version of ThreeJS and the actual newer versions of ThreeJS (because of npm's semver rules for anything below 0.X.X).

DoisKoh avatar May 16 '23 09:05 DoisKoh