Cas_
Cas_
https://github.com/ThaUnknown/jassub/actions/runs/10255187904
published as 1.7.17
hooray for my sanity! i figured it out, it was the realloc that was bad! this works, but I'm uncertain if its the correct way of doing it
`node-gyp-build` is pretty much the standard for native addons, and this is unironically the first one I've seen that doesn't use it, [it's not that big](https://github.com/prebuild/node-gyp-build/blob/master/node-gyp-build.js) and handles a LOT...
yeah it doesn't seem possible to do this zero-copy anymore because of changes in v8: https://www.electronjs.org/pt/blog/v8-memory-cage
yeah the way you want to do this is to check if the v8 trap is enabled, which I can't find how to do, and only do memcpy then, or...
> really see any edge cases, other than ones it introduces via prebuilds. pretty much yep, but other tooling uses that logic to compile binaries for very non-standard ecosystems, aka...
see, this is why prebuilds are nice, I can't build this on windows, as this version isn't published on npm, and using gh to load it, creates a massive "codeload"...
to answer your question, the code you pushed to master works on electron, but the command you provided doesn't, ignoring the fact that it doesn't work with electron's build system...
> √ Rebuild Complete No it fails during runtime, with a classic NAPI "Fatal Error" and no extra information, you can do `ELECTRON_RUN_AS_NODE=1 npx electron` [doesn't work in windows CMD...