rich
rich copied to clipboard
Custom message on `Live` overflow
Type of changes
- [ ] Bug fix
- [x] New feature
- [ ] Documentation / docstrings
- [ ] Tests
- [ ] Other
Checklist
- [x] I've run the latest black with default args on new code.
- [x] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
- [x] I've added tests for new code.
- [x] I accept that @willmcgugan may be pedantic in the code review.
Description
Allow a custom message with a Live overflows, instead of an ellipsis.
Bump @willmcgugan, could we at least run tests.
(Curious why you don't allow tests to run for all PRs?)
(Curious why you don't allow tests to run for all PRs?)
That used to be the case. Github changed it, and I haven't changed it back.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.98%. Comparing base (
45cc90b) to head (01bc82a). Report is 83 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #3702 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 74 74
Lines 8142 8147 +5
=======================================
+ Hits 7978 7983 +5
Misses 164 164
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 97.98% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Perhaps a
get_vertical_overflow_messagemethod, so it could be customized in a subclass.
On Live or LiveRender or both?
On
LiveorLiveRenderor both?
I think just Live. LiveRender isn't user-facing.