rich icon indicating copy to clipboard operation
rich copied to clipboard

Skip tests which are expected to fail with Python 3.14

Open befeleme opened this issue 9 months ago • 2 comments
trafficstars

Type of changes

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Documentation / docstrings
  • [x] Tests
  • [ ] Other

Checklist

  • [x] I've run the latest black with default args on new code.
  • [ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate. -- not sure this requires a changelog entry
  • [-] I've added tests for new code.
  • [x] I accept that @willmcgugan may be pedantic in the code review.

Description

In Fedora Linux, we've started testing packages with Python 3.14. When I deal with the (expected) failure of these 5 tests, rich builds just fine.

befeleme avatar Jan 28 '25 09:01 befeleme

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.98%. Comparing base (225cb07) to head (d094077). Report is 38 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3622      +/-   ##
==========================================
- Coverage   98.24%   97.98%   -0.27%     
==========================================
  Files          74       74              
  Lines        8105     8142      +37     
==========================================
+ Hits         7963     7978      +15     
- Misses        142      164      +22     
Flag Coverage Δ
unittests 97.98% <ø> (-0.27%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jan 28 '25 09:01 codecov-commenter

Would it make sense to have @skip_py311_or_later and @skip_other_than_py311 at this point?

hroncok avatar Jan 28 '25 13:01 hroncok

Thanks. The work was done in https://github.com/Textualize/rich/pull/3861

willmcgugan avatar Oct 09 '25 08:10 willmcgugan