ComfyUI-ELLA icon indicating copy to clipboard operation
ComfyUI-ELLA copied to clipboard

fp8 is not supported

Open emptybamboo opened this issue 1 year ago • 6 comments

The image generated in f8 mode will report an error Error occurred when executing T5TextEncode #ELLA:

"index_select_cuda" not implemented for 'Float8_e5m2'

emptybamboo avatar Apr 20 '24 19:04 emptybamboo

The f8 mode is not supported yet. I will take a look at this issue this week.

JettHu avatar Apr 21 '24 08:04 JettHu

I also run into the same issue. I really hope this get's fixed soon as fp8 enables much less vram usage.

CyberTimon avatar May 10 '24 10:05 CyberTimon

I really doubt that the ella node has been abandoned by Tencent, because it is also produced by Tencent, and the node of t-gate is updated very frequently, almost every day, but the ella node is rarely updated.😭

emptybamboo avatar May 10 '24 11:05 emptybamboo

I am too hoping for fp8 support.

LuLmaster69 avatar May 11 '24 12:05 LuLmaster69

Does anyone know how this got implemented in other repos? Maybe we can look at their code and do it ourselve.

CyberTimon avatar May 11 '24 15:05 CyberTimon

In fact, this is mainly a problem with T5. If anyone can provide me with a way to run T5 in FP8 mode, I would be very grateful.

And because the basic features of ELLA have been stabilized, we are doing some other work about EMMA recently.

JettHu avatar May 16 '24 07:05 JettHu