rapidjson icon indicating copy to clipboard operation
rapidjson copied to clipboard

Added polymorphism test and virtual functions

Open mondus opened this issue 1 year ago • 1 comments

Pull request fixes #2278 by making Writer class functions virtual to allow correct behaviour when PrettyWriter is cast to the base class.

Changes made

  • [x] Unit Test which ensures that PrettyWriter maintains pretty writing when cast to Writer
  • [x] Changes to Writer class functions to make them virtual

mondus avatar May 15 '24 17:05 mondus

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

tencent-adm avatar May 15 '24 17:05 tencent-adm