rapidjson icon indicating copy to clipboard operation
rapidjson copied to clipboard

CMake: Canonicalize rapidjson include path in RapidJSONConfig.cmake.

Open bastianbeischer opened this issue 6 years ago • 6 comments

Having the path without relative components allows other projects to add the RadidJSON_INCLUDE_DIRS as a system include directory, without causing problems in the build.

bastianbeischer avatar Apr 29 '19 11:04 bastianbeischer

CLA assistant check
All committers have signed the CLA.

tencent-adm avatar Apr 29 '19 11:04 tencent-adm

See discussion in:

https://github.com/MaskRay/ccls/pull/383

(specifically the last comment)

bastianbeischer avatar Apr 29 '19 11:04 bastianbeischer

Coverage Status

Coverage increased (+0.001%) to 99.922% when pulling c9b57bd5f7cfd0e3ad1e256dbab4a4dd28e8ad33 on bastianbeischer:cmake into 01950eb7acec78818d68b762efc869bba2420d82 on Tencent:master.

coveralls avatar Apr 29 '19 12:04 coveralls

Coverage Status

Coverage increased (+0.001%) to 99.922% when pulling c9b57bd5f7cfd0e3ad1e256dbab4a4dd28e8ad33 on bastianbeischer:cmake into 01950eb7acec78818d68b762efc869bba2420d82 on Tencent:master.

coveralls avatar Apr 29 '19 12:04 coveralls

I fixed issues with the install locations in PR #1454, see commits deecf8c17a9f8df15f59fe58e1b57184b2029a8b and 425c1e755f6ab4ea4f9c27a295a6339270ac1162.

Would that fix the problem? I think using configure_package_config_file is better.

smancill avatar Sep 10 '19 21:09 smancill

I fixed issues with the install locations in PR #1454, see commits deecf8c and 425c1e7.

Would that fix the problem? I think using configure_package_config_file is better.

Yes, your PR also fixes the problem.

bastianbeischer avatar Sep 11 '19 10:09 bastianbeischer