Hippy icon indicating copy to clipboard operation
Hippy copied to clipboard

feat(ios): rich text images support vertical alignment setting

Open wwwcg opened this issue 3 years ago β€’ 11 comments

Pre-PR Checklist

  • [x] I added/updated relevant documentation.
  • [x] I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • [x] I squashed the repeated code commits.
  • [x] I signed the [CLA].
  • [x] I added/updated test cases to check the change I am making.
  • [x] All existing and new tests are passing.

wwwcg avatar Oct 10 '22 11:10 wwwcg

πŸ‘‹ Thanks for your contributing!

Our collaborators will review your pull request after all status checks have been passed.

github-actions[bot] avatar Oct 10 '22 11:10 github-actions[bot]

After a quick scan, I have approved workflows to run.

hippy-service[bot] avatar Oct 10 '22 11:10 hippy-service[bot]

After a quick scan, I have approved workflows to run.

hippy-service[bot] avatar Nov 02 '22 07:11 hippy-service[bot]

After a quick scan, I have approved workflows to run.

hippy-service[bot] avatar Nov 02 '22 07:11 hippy-service[bot]

After a quick scan, I have approved workflows to run.

hippy-service[bot] avatar Nov 02 '22 12:11 hippy-service[bot]

After a quick scan, I have approved workflows to run.

hippy-service[bot] avatar Nov 02 '22 14:11 hippy-service[bot]

After a quick scan, I have approved workflows to run.

hippy-service[bot] avatar Nov 03 '22 08:11 hippy-service[bot]

After a quick scan, I have approved workflows to run.

hippy-service[bot] avatar Nov 04 '22 12:11 hippy-service[bot]

After a quick scan, I have approved workflows to run.

hippy-service[bot] avatar Nov 17 '22 07:11 hippy-service[bot]

After a quick scan, I have approved workflows to run.

hippy-service[bot] avatar Nov 21 '22 07:11 hippy-service[bot]

Codecov Report

Merging #2521 (0bea7b9) into master (9e7fb70) will increase coverage by 10.27%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2521       +/-   ##
===========================================
+ Coverage   62.36%   72.63%   +10.27%     
===========================================
  Files          30       67       +37     
  Lines        1990     4535     +2545     
  Branches        0      558      +558     
===========================================
+ Hits         1241     3294     +2053     
- Misses        749     1194      +445     
- Partials        0       47       +47     
Impacted Files Coverage Ξ”
packages/hippy-vue/src/renderer/list-node.js 0.00% <0.00%> (-53.85%) :arrow_down:
packages/hippy-vue/src/util/node.js 73.91% <0.00%> (-11.09%) :arrow_down:
packages/hippy-vue/src/runtime/node-ops.js 83.87% <0.00%> (-10.25%) :arrow_down:
packages/hippy-vue/src/runtime/native.js 32.52% <0.00%> (-6.77%) :arrow_down:
packages/hippy-vue/src/elements/built-in.js 87.01% <0.00%> (-4.77%) :arrow_down:
...ppy-vue/src/renderer/native/style/css-selectors.js 33.47% <0.00%> (-4.61%) :arrow_down:
packages/hippy-vue/src/renderer/native/index.js 81.30% <0.00%> (-3.90%) :arrow_down:
packages/hippy-vue/src/renderer/element-node.js 81.51% <0.00%> (-2.30%) :arrow_down:
packages/hippy-vue/src/util/index.js 66.27% <0.00%> (-0.39%) :arrow_down:
packages/hippy-vue/src/runtime/netInfo.js 78.94% <0.00%> (ΓΈ)
... and 47 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Nov 21 '22 07:11 codecov-commenter

Pay attention πŸ›ŽοΈ !! There has been no activity on this PR for 2 months, so I will label it stalled. It will be automatically closed in 30 days if no more activity. Feel free to leave a comment if you have any questions.

hippy-service[bot] avatar Feb 03 '23 19:02 hippy-service[bot]

CLA assistant check
All committers have signed the CLA.

tencent-adm avatar Feb 20 '23 10:02 tencent-adm

:tada: It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

  • SHA: 2d86f56de9f6c52c52541ee23c6b97f994cbaf21

hippy-service[bot] avatar Feb 22 '23 02:02 hippy-service[bot]