Cerberus icon indicating copy to clipboard operation
Cerberus copied to clipboard

Created a fluid AMP version of the template

Open JayOram opened this issue 3 years ago • 4 comments
trafficstars

Without changing the structure, only be editing the changes needed to make the original fluid template valid in AMP4Email.

JayOram avatar Feb 14 '22 20:02 JayOram

I see you created a few file here, does that mean we'd need to go from three templates to six to support AMP? I'm wondering if it's worth it. There is some previous discussion about whether or not to support AMP. Would love to hear your take.

TedGoas avatar Feb 14 '22 22:02 TedGoas

@TedGoas - as AMP supports classes and most HTML with less of the restrictions on HTML/CSS email templates, such as mso fixes/using th/hybrid/responsive/fluid etc. Just one version that I added would work for all of those modules in AMP.

JayOram avatar Feb 15 '22 22:02 JayOram

Just one version that I added would work for all of those modules in AMP.

What do you mean? Could we theoretically consolidate all three existing templates into a single AMP template since it's less code? Or would each template need it's own AMP version. Sorry for the dumb questions, I've not really worked with AMP emails before.

TedGoas avatar Feb 18 '22 14:02 TedGoas

Apologies I didn't explain myself very well and you can ignore the original pull request.

I thought each version of the cerberus template was identical in modules. AMP only works in one way - the closest would be responsive.

  • No need for inline styles
  • All styles can go in the head and no need for important
  • As AMP is supported across clients, no need for mso specific fixes etc. the AMP code will work across all email clients that support AMP4Email

I will code all of the modules from all of the cerberus templates into 1x supported AMP4Email template. Then add a new pull request.

JayOram avatar Feb 19 '22 16:02 JayOram