JavaDoc Deprecation is misleading.

[creatorfromhell]

For reference: https://github.com/TechnicallyCoded/FoliaLib/blob/5aea0f866df57ca03d00f5b199e89934f75f0989/common/src/main/java/com/tcoded/folialib/FoliaLib.java#L66

The method getImpl() was deprecated as of 0.3.5, but in the JavaDocs it points to getImplType, which doesn't return PlatformScheduler as getImpl did, instead getScheduler. This could be misleading to some folks looking at the docs.

[TechnicallyCoded]

Are you suggesting that getImplType be deprecated and replaced by getPlatformType or similar?

[creatorfromhell]

Are you suggesting that getImplType be deprecated and replaced by getPlatformType or similar?

No I'm suggesting that the javadoc could be misleading if someone used getImpl() to get the platform scheduler. The JavaDoc points them to the getImplType, which is pointed to the ImplementationType enum instead of PlatformScheduler. Unless the original return type was incorrect the entire time.

@SuppressWarnings("unused")
    public ImplementationType getImplType() {
        return implementationType;
    }

    /**
     * @deprecated Use {@link #getImplType()} instead. (forRemoval = true, since = "0.3.5")
     */
    @Deprecated
    @SuppressWarnings("unused")
    public PlatformScheduler getImpl() {
        return getScheduler();
    }

    public PlatformScheduler getScheduler() {
        return scheduler;
    }

[TechnicallyCoded]

Oh wait what, I just realized what you're pointing out... how did that get in there

[TechnicallyCoded]

I'm pretty sure this was updated, at least in development since then