TechnicSolder icon indicating copy to clipboard operation
TechnicSolder copied to clipboard

Why are modversions ordered by number and not by date

Open fcpwiz opened this issue 9 years ago • 4 comments
trafficstars

Since modversions are ordered by number the modversions are all out of order. For example, in a list ordered from oldest to newest modversions, 4.2.19 comes before 4.2.2 (because 1 is smaller than 2, but 19 isn't smaller than 2). It should be the other way around, that's why I think modversions should be ordered by date and not by number.

screen shot 2016-01-09 at 5 50 25 pm Look, 1.2.12 is the latest version, though it's in the middle of the list. This makes it easy to make a dumb mistake when picking the correct modversion.

fcpwiz avatar Jan 09 '16 22:01 fcpwiz

Dupe #492 - sort of

spannerman79 avatar Jan 09 '16 22:01 spannerman79

@spannerman79 Yeah I have that issue too. Really really annoying. Seems like an easy fix if all builds were dated and sorted by that and not by number.

fcpwiz avatar Jan 09 '16 22:01 fcpwiz

Only issue is the weird way that some mod devs number their build versions. Not to mention sometimes a modder (or two) just re-uploads the same version number when clearly there has been changes made. CustomNPC is one such mod :frowning:

It would be "nice" if mod devs followed some sort of correct versioning system. Hell even at the end (if they use Travis/Jenkis/etc) they can stick their build numbers on the end themselves if they wish.

spannerman79 avatar Jan 09 '16 23:01 spannerman79

This https://github.com/TechnicPack/TechnicSolder/blob/master/app/views/modpack/build/view.blade.php#L85 should be changed to ->sortByDesc('updated_at', SORT_NATURAL).

heddendorp avatar Jan 22 '16 23:01 heddendorp