FrameworkBenchmarks icon indicating copy to clipboard operation
FrameworkBenchmarks copied to clipboard

Removing Host header from wrk command line

Open sebastienros opened this issue 5 years ago • 2 comments

Would it make sense to remove the Host header argument form the wrk command line: https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/toolset/wrk/pipeline.sh#L31

Since wrk will include it either way based on the target url. I haven't measured the perf impact on the load server, but at least it would simplify the command line.

sebastienros avatar Sep 03 '20 16:09 sebastienros

And Connection: keep-alive is also implicit in HTTP 1.1

sebastienros avatar Sep 03 '20 16:09 sebastienros

Our manually-specified Host header is also wrong because it does not include the port number. Agreed, it makes sense to let wrk set this.

We assume removing Connection: keep-alive would cause an increase in throughput -- it would decrease the size of requests over the network and reduce the header-parsing burden of the server -- resulting in some churn in the results, but internally no one had a problem with this.

michaelhixson avatar Sep 22 '20 21:09 michaelhixson