FrameworkBenchmarks icon indicating copy to clipboard operation
FrameworkBenchmarks copied to clipboard

Clarify plaintext urls specifications

Open sebastienros opened this issue 5 years ago • 3 comments

The specs currently suggest routes like /plaintext, /json, ... However since Plaintext is network-bound right now, using smaller ones makes a difference, which can be seen with pico.v and that I have been able to confirm on ASP.NET. There is currently a PR for Actix that does the same, and I would love it to be merged to confirm the impact.

I think it would be fair and be explicit that it's either recommended to use /p for perf, or otherwise required to use /plaintext.

sebastienros avatar Apr 03 '20 19:04 sebastienros

@sebastienros I did merge this. I'd like to see the impact as well. After discussing internally, we're going to make the routes required after this round. I'll make a change to the rules here shortly for round 20 and beyond.

NateBrady23 avatar Apr 06 '20 16:04 NateBrady23

@nbrady-techempower I understand not wanting to go through wholesale and enforce this rule for every framework in round 19, but I feel like at the very least it should should be enforced for the to 15 plaintext frameworks since they are all fast enough to hit the bandwidth limitations.

Allowing pico.v, actix and aspcore to use this technicality sends an unnecessarily misleading signal to anyone who quickly looks at the top 10 list.

talawahtech avatar Apr 24 '20 02:04 talawahtech

@talawahtech I appreciate your input but we’ve already made the decision to enforce this for round 20 and beyond. The round is closed next week.

NateBrady23 avatar Apr 24 '20 02:04 NateBrady23