NewPipe
NewPipe copied to clipboard
TeamNewPipe
Add the Switch to Pop-up/Background player buttons back
Checklist
- [x] I checked, but didn't find any duplicates of this issue in the repo.
- [x] I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
- [x] This issue contains only one feature request. I will open one issue for every feature I want to request.
Describe the feature you want
Before update 20.0 there use to be certain buttons in the video player that or now missing. Where the open in youtube button is now, there used to be the background player and pop out button, along with a force video rotation button. The force rotation button was especially useful for watching vertical videos. I know that pop out and background player got moved below the video but it was easier to access these features when watching in full screen mode. Also, the video player doesn't automatically go to full screen in portrait orientation, so if that could be reverted.
Is your feature request related to a problem? Please describe it
These features are not problems, but a matter of convenience. Instead of leaving fullscreen to access them, there were right on the video player.
Additional context
Add any other context, like screenshots, about the feature request here
If you add this back I'll buy the devs big Macs.
How will you/everyone benefit from this feature?
This is a useful feature for users who watch videos in full screen mode, as most people do. Instead of exiting the video they can make adjustments from there and not ruin the emersion or viewing experience.
About the background and popup buttons, I could agree with you. But why would you need an autorotation button? Now everything is handled automatically: vertical videos are detected as such and their orientation is changes; fullscreen is activated automatically by rotating the device (if autorotation is active); ...
If you add this back I'll buy the devs big Macs.
;-)
I guess if it's all automatic then auto rotate isn't needed but I would still like the background player and pop out buttons back. Also why wouldn't videos automatically go to full screen when played even if the phone isn't horizontal. Who watches video in the default mode where you can see the channel and comments section?
Where do I send the Big Macs?
@Ferrero11 https://liberapay.com/TeamNewPipe/ :) There is also a Bitcoin address on https://newpipe.schabi.org/donate/
When the update comes out I'll buy it as long as it's not to much. How many devs am I buying for?
@Ferrero11 I'm here to save the day. 😎
Regarding pop-up and background buttons:
- In video details page: they are right there, no issue.
- Full screen (orientation unlocked): Rotate the phone and use the buttons.
- Full screen (orientation locked): Swipe up on full screen button and use them.
Regarding force rotation button: Did you read the relevant section in the blog post? If not, make sure you do. The full screen button has been worked on extensively. It can do everything you're asking for.
@opusforlife2 I know they are in the video details page but they used to be where the "open in youtube" button is now across from the captions button. This was a useful place for them since they could be accessed in full screen mode without exiting the video. The problem with swiping up from the bottom to access these buttons is that for people who use gestures, swiping up from the bottom activates gestures like google assistant and recent apps sometimes. Putting them next to the share and mute buttons in the drop down menu would let you keep watching the video while accessing these buttons.
I miss that rotation button too. I sometimes watch videos in full screen mode but not vertical.
https://github.com/TeamNewPipe/NewPipe/issues/4407
-
going from popup to full screen now requires more actions than before
-
add option in settings to disable automatic rotation to get that rotation button back
I wish for all those buttons to return: rotation by pressing a button in fullscreen, popout by pressing a button in fullscreen, background player by pressing a button in fullscreen. I used all of those. With the inline player you can watch vertically, but only in one (the default) aspect ratio.
100% agree! i did downgrade again to 1.9 after seeing that they removed the buttons. i always used them & the fact that i now need 2 clicks instead of just 1 to go to fullscreen etc. is just annoying.. before that you could click on the play button on the video page and it did playback the video in fullscreen without having to enable rotation etc etc.. now it's just messed up and annoying.
this issue is closed so go to the PR they linked to make comments @hipunk @hp8wvvvgnj6asjm7 @Kusurisan
@Stypox
About the background and popup buttons, I could agree with you. But why would you need an autorotation button? Now everything is handled automatically: vertical videos are detected as such and their orientation is changes; fullscreen is activated automatically by rotating the device (if autorotation is active); ...
With the exception that you can no longer watch vertical videos in landscape. And if you're thinking "why would you want to do that?" simply queue up a mix of horizontal and vertical videos, disable auto-rotate and then start watching the videos in landscape. When you get to a vertical video it'll be sideways, so you need to physically rotate your phone to watch that video. You previously didn't need to do this.
Can I tagalong this thread and share my 2 cent? I'm hoping for share button on popup player. It took me really long to find the share button at current version.
I also wish that on notification panel the close button is showing at right side like in old version. Currently I have to press the down arrow to find the close button.
You can customise the buttons which show for the 5 button row and the 3 button row.
Holy cow, didn't know about that feature. That's awesome.
On Wed, Oct 7, 2020, 6:39 PM opusforlife2 [email protected] wrote:
You can customise the buttons which show for the 5 button row and the 3 button row.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TeamNewPipe/NewPipe/issues/4414#issuecomment-704891793, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFZEFJVTSRFGLTKJUQUGY3SJRLBDANCNFSM4SE35CEQ .
Guys, I removed all those useless buttons. You can blame me. You may think they are useful. Yes, maybe. But NOT IN THE PLACE WHERE THEY WERE LOCATED.
You already have popup and background buttons under the player. Copying them to the player itself is a anti-smart idea in the current UI. Because now the buttons under the player is accessible. The problem is that the buttons is hardly accessible. Yes, this is a place for improvement. And instead of arguing you may give an idea of what way the devs may choose for an easy access to the buttons under the player.
TobiGr suggested to create a center zone in the player which will allow to swipe from bottom to top to show UI under a video such as buttons, comments, and so on. From my point of view it's the best solution. If you have other ideas share them with us.
TobiGr suggested to create a center zone in the player which will allow to swipe from bottom to top to show UI under a video such as buttons, comments, and so on. From my point of view it's the best solution. If you have other ideas share them with us.
I think this and the new enqueue #4425 sould be rushed ASAP. imo all of these complaints are because people used to use newPipe in certain way and was disrupted by the new update, which is normal... however the problem lies that the new update did not include sufficient alternative tools to balance, perhaps those and other PRs should be rushed in the form of a 0.20.1 update or something like that. either this or we risk a negative response from users.
@avently If you think about the priority of the buttons, some should be switched. Are you more likely to be watching a video and want to quickly switch to a different player, or to open the video in an external browser? If the devs don't want to add the player buttons back to the drop down menu, then maybe do this to satisfy both parties:
Keep the background player and pop up player buttons where they are in the video description. When you tape the globe to open the video in a browser have it instead open a pop out window like the tempo adjuster. Have three options on this pop out:
- open in external browser
- background player
- pop out player
This will allow the number of buttons to stay the same in both places, and the look will be the same, but the people who wan the buttons back in the drop down will have them there hidden away from the people who don't want them there. My other solution would be adding an option in settings to select which buttons you want in the drop down like you can select with the notification shade player. this would allow each user to choose which buttons you have in that menu. If you dont use certain ones, you wouldn't put them there
What I think we have with 0.20.0 is a case where the devs are narrowly focusing on their use cases, rather than thinking about accessibility or flexibility. If they didn't like something, they cut it. (See avently's https://github.com/TeamNewPipe/NewPipe/issues/4152#issuecomment-686628176 for an even clearer example than their "useless buttons" comment above).
I don't like a single one of the UI changes in 0.20. Not a single one - I want options to revert everything, not just a few things like autoplay. For now, I've gone back to 0.19.8, but that's short term - we all know Google will break NewPipe soon enough, and I'll be forced off 0.19.8 when that happens.
I want to force rotation without turning autorotate on (since I want to read in portrait, not have it shuffle randomly when I'm lying on my side, I keep autorotate off. I don't actually care about the popout button and would really prefer to disable everything related to popouts since I don't use it, but people should have it if they want it) - although, TBF, I never found that option in <0.20 because it was hidden. I actually sent a video to VLC more than once because I didn't realise it existed... (A force 4:3 option would be nice for videos uploaded wrong - Fit/Fill/Zoom don't cover that, might open a new bug for that.... That's another thing I've sent to VLC for - which I can't do without starting to play the video in 0.20....)
I don't want videos to play on the details page, or keep playing after I leave them unless I fiddle about for an X button. I want to be able to open in browser/"share"/etc from the details page (without autoplay), If I'm in a restricted bandwidth setting (or an unusually UNrestricted bandwidth setting, for that matter), I don't want to have to start playing the video or go all the way to the settings page to be able to change quality.
tl;dr - I want to be able to set up everything about the video and how/where it's playing before it plays without having to change global settings or swipe around for mystery meat navigation.
All the GUI changes in 0.20 seem to be about forcing us into a smaller box so that we use the app exactly the same way the devs who made these changes do. Regardless of whether we have good reason to prefer the old version or not.
0.20.0 is a case where the devs are narrowly focusing on their use cases
It's not true, you can read my initial PR and related discussion about unified player
I don't want videos to play on the details page, or keep playing after I leave them unless I fiddle about for an X button.
Disable autoplay and disable background playback (set it to None)
clearer example
It's clear example of how I feel like when two buttons sets have the same action (inside player and outside player). Popup and background buttons under the player are useful.
I don't like a single one of the UI changes in 0.20.
Looks like you mad because a couple of features work in different way. That's not a big problem, all of the mentioned issues can be fixed almost easily.
I want to force rotation without turning autorotate on
And whats the problem with current release? Or you have a tablet layout too? If so, I think someone will make an option to instruct NewPipe to act like a phone instead of tablet in case of rotation mechanism.
I want to be able to open in browser/"share"/etc from the details page (without autoplay),
I can only agree with this. This is downside of my changes and we search an alternative. There is an issue already which you can use for sending ideas.
I don't want to have to start playing the video or go all the way to the settings page to be able to change quality.
This will not be changed, it's a new workflow
All the GUI changes in 0.20 seem to be about forcing us into a smaller box so that we use the app exactly the same way the devs who made these changes do. Regardless of whether we have good reason to prefer the old version or not.
Nope, it's about easy to use UI and a new workflow
This will not be changed, it's a new workflow
I disagree. I might have 1080p as default quality as I normally want that at home, but sometimes I might want to watch a video elsewhere and then I don't want to waste my 4G data on 1080p while a lower resolution would be OK.
Don't we have "Limit resolution when using mobile data" for that particular use case?
@opusforlife2: Hmm… I didn't know that, does that actually limit the resolution (i.e. I can't switch to a higher one if I want)?
clearer example
It's clear example of how I feel like when two buttons sets have the same action (inside player and outside player). Popup and background buttons under the player are useful.
And see, I WANT the options "inside player and outside player". When I enter a video, I don't want to have to fiddle about with things after it's already playing. Ideally, I would want EVERY setting in the player to be available from the details page.
I don't like a single one of the UI changes in 0.20.
Looks like you mad because a couple of features work in different way. That's not a big problem, all of the mentioned issues can be fixed almost easily.
They could if you gave the options to revert all the changes, not just some.
I want to force rotation without turning autorotate on
And whats the problem with current release? Or you have a tablet layout too? If so, I think someone will make an option to instruct NewPipe to act like a phone instead of tablet in case of rotation mechanism.
#4152
Where you argue that "making the video automatically rotated to landscape from portrait on play looks ugly" and admit you sound "unpleasant" over it and call it an "anti-feature". It's a core feature for me. I made a post directly about it on that issue thread: https://github.com/TeamNewPipe/NewPipe/issues/4152#issuecomment-703945152
I can only agree with this. This is downside of my changes and we search an alternative. There is an issue already which you can use for sending ideas.
But it wouldn't even be an issue searching for a solution if you hadn't removed the bar where it was.
I don't want to have to start playing the video or go all the way to the settings page to be able to change quality.
This will not be changed, it's a new workflow
And again, based on your personal use cases. You don't use it, don't like it, so it goes - same as your "unpleasant" post in #4152
All the GUI changes in 0.20 seem to be about forcing us into a smaller box so that we use the app exactly the same way the devs who made these changes do. Regardless of whether we have good reason to prefer the old version or not.
Nope, it's about easy to use UI and a new workflow
So, the GNOME Shell attitude of cutting usability in the name of "ease of use"?
And as I said in that #4152 post I linked above, many of the changes are adding friction in the form of extra clicks or having to change global settings rather than on an individual video. Two clicks is never a more "easy to use UI" than one.