NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Feature Request: Select Different Download Path in Download Dialog

Open magi44ken opened this issue 6 years ago • 24 comments

In the Download Dialog, add an option to change the default download path to easily manually save to different folders.

magi44ken avatar Apr 12 '19 22:04 magi44ken

This is configurable in settings?

I could instead add the possibility of editing the default path by hand (i.e, through the keyboard), since I have Android Nougat and the default path (/storage/emulated/0/Movies/NewPipe) is somehow not reachable by any non-root user. However, /sdcard/Movies/NewPipe is. When I try to set it through the default path browser, /sdcard/ is empty (like if it was not allowed to browse into it).

I had to manually edit the org.schabi.newpipe.preferences.xml to enable the downloads again.

pacorrop avatar Apr 13 '19 16:04 pacorrop

Yes you change default path in the settings but I want to be able to do in download dialog. There are times I want to save to different folder beside the default folders in the settings.

magi44ken avatar Apr 13 '19 17:04 magi44ken

Sounds like a good idea and should be easy to implement

TobiGr avatar Apr 13 '19 17:04 TobiGr

hey can anybody guide on how to make it possible . because it currently get location from newpipesetting . so , my doubt is should the user type in the name of folder. or is there any other way.

sherlockbeard avatar Apr 15 '19 22:04 sherlockbeard

It would probably be best to open the android file manager to select where to download to. Typing in the path may cause issues if NewPipe ever ends up supporting downloading to SD card.

gkeegan avatar Apr 16 '19 02:04 gkeegan

i started the file explore but i am not sure how to get result from it. does anyone have any experience with it.

sherlockbeard avatar Apr 16 '19 09:04 sherlockbeard

Please do not use the Android File picker, but the FilePicker library. You can find its usage here: https://github.com/TeamNewPipe/NewPipe/blob/2d39e65b5cf204ea80d74c7d7919315bbfbd6d8e/app/src/main/java/org/schabi/newpipe/settings/DownloadSettingsFragment.java#L53

However, @kapodamy has just added a storage access framework and other things related to file handling. So it might be clever to build upon the work in #2149 and check which changes @kapodamy made to the way the filepicker is used.

TobiGr avatar Apr 16 '19 09:04 TobiGr

Thanx @TobiGr . I did the fix. using FilePickerActivityHelper

sherlockbeard avatar Apr 16 '19 12:04 sherlockbeard

Hello! I would like to work on this :)

please assign me this issue

MuhammadImran2 avatar Sep 15 '23 21:09 MuhammadImran2

damn flashback of 2019 .....

sherlockbeard avatar Sep 16 '23 09:09 sherlockbeard

hahahahah sorry i do no see time ok

MuhammadImran2 avatar Sep 16 '23 14:09 MuhammadImran2

hi @MuhammadImran2 plz free to take this as i can't contribute to it .

sherlockbeard avatar Sep 16 '23 14:09 sherlockbeard

ok @sherlockbeard :heart:

MuhammadImran2 avatar Sep 17 '23 12:09 MuhammadImran2

@MuhammadImran2 Please wait for confirmation before working on this. The current codebase is on a feature freeze right now because of an upcoming rewrite. So this may or may not be postponed because of that.

opusforlife2 avatar Sep 18 '23 20:09 opusforlife2

This needs to wait until after the rewrite or at least until the download handling was refactored

TobiGr avatar Sep 19 '23 10:09 TobiGr

ok @TobiGr

MuhammadImran2 avatar Sep 19 '23 12:09 MuhammadImran2

@MuhammadImran2 Still, I'm assigning this to you so we can keep track of this for later.

opusforlife2 avatar Sep 19 '23 18:09 opusforlife2

ok

MuhammadImran2 avatar Sep 20 '23 17:09 MuhammadImran2

@MuhammadImran2 ?

opusforlife2 avatar Sep 21 '23 17:09 opusforlife2

sorry friend mistakenly click on unAssignees but please assign me thank you

MuhammadImran2 avatar Sep 22 '23 11:09 MuhammadImran2

❤️

MuhammadImran2 avatar Sep 22 '23 17:09 MuhammadImran2

Can i work on this issue?

Gc0rp avatar Oct 08 '24 23:10 Gc0rp

@ShareASmile could you make me the assignee?

Gc0rp avatar Oct 09 '24 22:10 Gc0rp

Hey @Gc0rp! Thanks for showing an interest in contributing. Unfortunately, the app is undergoing a major refactor right now, and devs are discouraged from sending in feature PRs. You can still do so, but there's a very low probability of them being reviewed any time soon. If you're still okay with that, please go ahead!

opusforlife2 avatar Oct 10 '24 15:10 opusforlife2