NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Speed up with touch control

Open Rockbard opened this issue 7 years ago • 14 comments
trafficstars

Feature request: Speed up videos with touch control instead of brightness control (as an option) Purpose: Watching tutorials on youtube will be great if you could quickly speed up video and turn on a normal play speed when needed with convenient touch control Note Volume pitch should be at 100%

Thanks, Dmitry

Rockbard avatar Oct 17 '18 09:10 Rockbard

What if the speed setting is with swiping left to right (instead up to down)?

bkqtnte10 avatar Oct 23 '18 19:10 bkqtnte10

Right to left is filling better as time search function. That's a pretty a match standard for all players. In my opinion brightness with the up and down gesture is arguable, as I accidentally touching it all the time. But that a standard gesture for most of the players too.

Maybe (just an idea) speed is up and down gesture on the left, brightness in the middle and volume on the right side?

Rockbard avatar Oct 23 '18 19:10 Rockbard

IMO, three gestures are too much. But @ritiek made it possible in #1644 to disable either the volume or brightness control or even both. So if someone implements a third logic which handles the speed and restricts the maximum number of enabled gestures to two, I'd be okay with this. @theScrabi @ritiek What do you think?

TobiGr avatar Oct 24 '18 11:10 TobiGr

This should be a good addition. The only caveat I can think of is that three gestures enabled all at once might cause some trouble in triggering the correct behaviour but this shouldn't be a problem as one would be able to disable the gestures they don't need.

Maybe (just an idea) speed is up and down gesture on the left, brightness in the middle and volume on the right side?

Just my $0.02. IMO as @bkqtnte10 mentioned it would be nicer to have the speed gesture as swiping left-right on any part of the screen. Currently, swiping top-down on the left part of screen affects the brightness and on the right part of screen affects the volume. In the same way, swiping left-right on any part of the screen would affect the playback speed.

In this way, we would be able to have all three gestures (brightness, volume, playback speed) enabled at the same time.

ritiek avatar Oct 24 '18 15:10 ritiek

Still think that left/right gesture is better to use for the rewind function.

My vote is probably is to do the option of choosing wich action you want to use for the left side up and right gesture, brightness or speed.

Imagine you watching the video and the there goes the boring part, you swiping up on the left side and the video playing faster, you see the interesting part comes and just swiping down to set the default playing speed. Would be great to see this kind of control in other players too

ср, 24 окт. 2018 г., 18:32 Ritiek Malhotra [email protected]:

This should be a good addition. The only caveat I can think of is that three gestures enabled all at once might cause some trouble in triggering the correct behaviour but this shouldn't be a problem as one would be able to disable the gestures they don't need.

Maybe (just an idea) speed is up and down gesture on the left, brightness in the middle and volume on the right side?

Just my $0.02. IMO as @bkqtnte10 https://github.com/bkqtnte10 mentioned it would be nicer to have the speed gesture as swiping left-right on any part of the screen. Currently, swiping top-down on the left part of screen affects the brightness and on the right part of screen affects the volume. In the same way, swiping left-right on any part of the screen would affect the playback speed.

In this way, we would be able to have all three gestures (brightness, volume, playback speed) enabled at the same time.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TeamNewPipe/NewPipe/issues/1823#issuecomment-432706455, or mute the thread https://github.com/notifications/unsubscribe-auth/AllDlFgl9QA5fNJTauZUbZ_9ung-ratRks5uoIgbgaJpZM4Xjc6R .

Rockbard avatar Oct 25 '18 20:10 Rockbard

If someone is looking into this, #1536 is related. Remember playback speed changes between videos.

Tikotik avatar Oct 31 '18 14:10 Tikotik

How about left/right gesture on top half of the screen to control video play speed/tempo and left/right gesture on bottom half of the screen for rewind/forward video time?

androidSwDev099 avatar Apr 28 '20 01:04 androidSwDev099

There's also the two finger up/down gesture, like in MX Player, for example. This way you can easily have three gestures without confusion (in MX Player there's also a zoom gesture, which does get in the way, but you can disable it in the settings).

Personally, I change speed more often than brightness, so I'd relegate the brightness gesture to "two fingers" and make speed changing easier by having it on the left in place of the current brightness gesture.

dardoor avatar Jul 17 '20 11:07 dardoor

from reading all the comments, my suggestion is to have gestures as fallow

  1. right to left for seek
  2. up/down on the left for brightness
  3. up/down on the middle for speed
  4. up/down on the right for volume

the up/down gestures should fallow the three double tab zones.. this way although there are three active up/down gestures, they are clearly distinguished by the three zones that the users are already familiar with.

but to tell you the truth I don't think this feature is a most as the speed button is close enough for fast changes.

MD77MD avatar Jul 18 '20 10:07 MD77MD

but to tell you the truth I don't think this feature is a most as the speed button is close enough for fast changes.

I disagree. I think even just copying the MX Player gesture would make it significantly faster and nicer.

Three zones could work too, but it would probably be too crowded at that point and lead to mistakes, especially in portrait mode.

dardoor avatar Jul 31 '20 10:07 dardoor

I think the whole where to put what debate is useless, just implement 3 gestures up-down-left, up-down-right and left-right and also the code to change playback speed and playback position and let the user pick how they want to connect them, just like android gestures for lock screen.

AnonymousSeal avatar Sep 11 '20 13:09 AnonymousSeal

Maybe it could be implemented like this:

  • tap and hold right side of screen increases tempo by +75%, after release back to previous tempo
  • tap and hold left side of screen decreases tempo by -75%, after release back to previous tempo

(perhaps additionally change the tempo if the finger is moved further left/right.

bkqtnte10 avatar Dec 17 '22 14:12 bkqtnte10

Any progress on this?

fritzrehde avatar Jan 13 '24 22:01 fritzrehde

Let's keep the two adjustment areas as they are now, but allow users to choose between Volume, Brightness, and Speed control on both sides.

Speed adjustment could resemble Brightness and Volume, with the radial line moving along the circle.

As an example, I currently use Volume Adjust on both sides. If there were a Speed Adjusting option to choose, I would definitely use it for my left adjustment area.

Rockbard avatar Jan 22 '24 12:01 Rockbard