codestream icon indicating copy to clipboard operation
codestream copied to clipboard

GitLab/GitLab SM support for viewing/reviewing MRs

Open apatryda opened this issue 4 years ago • 7 comments

Even though I have the self-managed GitLab integration turned on, I cannot neither list nor open (by providing an url) merge requests in my IDE (vscode). When I provide a direct URL to the MR I get the following error message: t[e.method] is not a function.

image

apatryda avatar Jan 12 '21 22:01 apatryda

@apatryda - Unfortunately, the ability to view/review PRs isn't available yet for GitLab (or Bitbucket). Only for GitHub/GitHub Enterprise. That said, we're working on support for GitLab and GitLab SM right now. I'll update you here once it's available.

planteater avatar Jan 12 '21 22:01 planteater

My apologies Artur! I just now connected the dots between this report and our conversation via support. :-)

planteater avatar Jan 12 '21 22:01 planteater

No need :smiley:, thanks for connecting the dots and good luck on the feature :crossed_fingers:

apatryda avatar Jan 13 '21 23:01 apatryda

A note for GitLab SM: self managed instances of GitLab can be (and often are) hidden behind firewals, so if access is required from CodeStream servers - information on required firewall rules would be a nice thing (like at least a list of the IP's of CodeStream servers that might query the GitLab instance).

apatryda avatar Jan 13 '21 23:01 apatryda

It seems to be a duplicated issue, please check out #352.

liuliangsir avatar Jan 20 '21 01:01 liuliangsir

@liuliangsir - I wouldn't say it's a duplicate. I'd rather say those issues are related.

apatryda avatar Jan 25 '21 12:01 apatryda

You can help/monitor progress on gitlab-prs branch: https://github.com/TeamCodeStream/codestream/compare/feature/gitlab-prs

apatryda avatar Feb 02 '21 03:02 apatryda

GitLab support was added some time ago but I never closed this.

planteater avatar Aug 14 '22 14:08 planteater