codestream icon indicating copy to clipboard operation
codestream copied to clipboard
verified publisher icon TeamCodeStream

Allow a comment to be marked as a change-request when editing

Open natanavra opened this issue 5 years ago • 2 comments

  1. Create a comment (forget ticking "Change Request")
  2. Edit the comment and tick "Change Request"
  3. Save
  4. Nothing happens

Expected result: Change request should be added.

natanavra avatar Jul 09 '20 07:07 natanavra

@natanavra - In theory, you shouldn't be able to go back and turn a regular comment into a change request, but maybe we've got a loophole in there somewhere. Can you let me know the steps to reproduce this? I created a comment in a review, then went to edit it, and there was no change-request checkbox there. But maybe you're doing something slightly different than me. Also let me know what IDE you're using and which version of CodeStream. Thanks!

planteater avatar Jul 09 '20 18:07 planteater

You should be able to do so.

I suggest also a hotkey like SHIFT + ENTER that automatically checks change request, and also global setting to make it default (I for instance rarely comment on code, everything is change request which makes me often forget to click it).

majkinetor avatar Jul 23 '20 07:07 majkinetor