form icon indicating copy to clipboard operation
form copied to clipboard

fix(core): Fixed issue with multiple validation triggers and resolved…

Open rjsdnql123 opened this issue 1 year ago • 4 comments

https://github.com/TanStack/form/issues/905

While resolving this issue, I also fixed the repeated execution of setTimeout.

rjsdnql123 avatar Sep 30 '24 15:09 rjsdnql123

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c402412441cad4ccb60f847c22e22d36864a079. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Oct 01 '24 16:10 nx-cloud[bot]

Open in Stackblitz

More templates

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@962
@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@962
@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@962
@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@962
@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@962
@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@962
@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@962
@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@962
@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@962

commit: 1c40241

pkg-pr-new[bot] avatar Oct 01 '24 16:10 pkg-pr-new[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.43%. Comparing base (5473bb8) to head (1c40241). Report is 143 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
- Coverage   91.55%   88.43%   -3.13%     
==========================================
  Files          21       26       +5     
  Lines         900     1072     +172     
  Branches      206      264      +58     
==========================================
+ Hits          824      948     +124     
- Misses         71      115      +44     
- Partials        5        9       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 01 '24 16:10 codecov[bot]

@Balastrong Got it! 👾

rjsdnql123 avatar Oct 05 '24 09:10 rjsdnql123

I can't think of an easy way to test this in our current setup, and it clearly looks like a super clean PR so I'm gonna merge it. Please feel free to make another PR with tests if you can figure them out! :)

Thanks for this!

crutchcorn avatar Oct 22 '24 05:10 crutchcorn