form icon indicating copy to clipboard operation
form copied to clipboard

fix: insert value behaviour

Open Balastrong opened this issue 1 year ago • 2 comments

This PR closes #696

As mentioned on Discord, this should be the expected behavior of "inserting a value into an array".

Balastrong avatar May 02 '24 19:05 Balastrong

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9a4107b42da0efc9ca33738b5d1662dc2f63453c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar May 02 '24 19:05 nx-cloud[bot]

I think this is correct. Can we add in a new replaceFieldValue to act like the old insertFieldValue API? I'm more than happy to merge if we're able to add that + some minor tests :)

crutchcorn avatar May 02 '24 20:05 crutchcorn

NxCloud is having errors, but pnpm test:ci works locally and I have high confidence in these changes. Merging!

crutchcorn avatar Jun 03 '24 06:06 crutchcorn