form icon indicating copy to clipboard operation
form copied to clipboard

Remove SubField API

Open crutchcorn opened this issue 1 year ago • 2 comments

This PR removes the subfield API from FieldAPI, as:

  1. We're removing the implicit ability to create a new FieldAPI from a parent's name in react-core (#588)
  2. This API adds a ton of complexity (especially around typings)
  3. It's just as easy to new FieldAPI with a new name

crutchcorn avatar Feb 25 '24 07:02 crutchcorn

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8f70742839b3309a803bec99485ec038cf652cde. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Feb 25 '24 07:02 nx-cloud[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.75%. Comparing base (9602113) to head (8f70742). Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   87.78%   87.75%   -0.04%     
==========================================
  Files          30       30              
  Lines         794      792       -2     
  Branches      179      179              
==========================================
- Hits          697      695       -2     
  Misses         92       92              
  Partials        5        5              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 25 '24 07:02 codecov-commenter