form icon indicating copy to clipboard operation
form copied to clipboard

Remove UID and Field Instances

Open crutchcorn opened this issue 1 year ago • 3 comments

This PR removes the concept of multiple instances of a Field for a given name, which in turn removes UID and, in happenstance, fixes #571.

This should be good-to-go, but breaks the ability to have multiple Field items with the same name. The question is if any of the @TanStack/form-maintainers can think of a reason why we might need that.

crutchcorn avatar Feb 25 '24 07:02 crutchcorn

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2c94f77455c7259e10d5954be26b156663523cf2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Feb 25 '24 07:02 nx-cloud[bot]

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.59%. Comparing base (b28f6d8) to head (a398a7b). Report is 1 commits behind head on main.

Files Patch % Lines
packages/form-core/src/FieldApi.ts 83.33% 1 Missing :warning:
packages/react-form/src/useField.tsx 66.66% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   87.78%   87.59%   -0.20%     
==========================================
  Files          31       31              
  Lines         819      822       +3     
  Branches      184      186       +2     
==========================================
+ Hits          719      720       +1     
- Misses         95       97       +2     
  Partials        5        5              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 25 '24 07:02 codecov-commenter

Updating some of this code based on: #576

crutchcorn avatar Feb 25 '24 18:02 crutchcorn