glide-support icon indicating copy to clipboard operation
glide-support copied to clipboard

GlideImageGetter for latest glide versions

Open mwshubham opened this issue 6 years ago • 7 comments
trafficstars

For the Html Image getter using Glide https://github.com/TWiStErRob/glide-support/blob/master/src/glide3/java/com/bumptech/glide/supportapp/github/_1062_html_gif_spans/GlideImageGetter.java Can you please let us know if this can be used in production. Also can you post the equivalent compatible with the latest build version.

Thank you.

mwshubham avatar Feb 20 '19 13:02 mwshubham

Hi, are you asking for permission or maturity?

I tried to make it work to my best knowledge, not sure if there are edge cases where it wouldn't work.

I haven't used Glide 4 in depth yet, try to apply https://bumptech.github.io/glide/doc/migrating.html to the class.

TWiStErRob avatar Feb 20 '19 15:02 TWiStErRob

Thanks for your reply. I hope you give us permission to use this code in production. I asked for the maturity of the code since the description of the project says to test out ideas from the issues. Also, I am not an expert thus requested for the v4 port as the library seems to be pretty changed from v3 to v4. Thanks for specifying the class let me try to migrate it to v4.

mwshubham avatar Feb 20 '19 16:02 mwshubham

Feel free to use/change it (https://github.com/TWiStErRob/glide-support#license-and-stuff). The goal of this was to demonstrate issues, but https://github.com/bumptech/glide/issues/1062 was a question so it should be fine, also https://github.com/bumptech/glide/issues/1062#issuecomment-198467333. Let me know how v4 goes, happy to publish it hear, or you can PR it.

TWiStErRob avatar Feb 20 '19 17:02 TWiStErRob

I was able to replicate the same for v4. However, I end up with two wrapper target one for drawable and one for gif drawable viz GifWrapperTarget WrapperTarget (Maybe I am bad in generics). Also, i wasn't able to find alternative of WrapperTarget class which was removed in v4. Hopefully will try to do more generic approach with DrawableWrapper or other in upcoming days.

mwshubham avatar Feb 22 '19 11:02 mwshubham

I can try to help if you raise a PR here to share code

TWiStErRob avatar Feb 22 '19 11:02 TWiStErRob

ok, I will raise the PR ASAP.

mwshubham avatar Feb 22 '19 11:02 mwshubham

no hurry, I'm at work :)

TWiStErRob avatar Feb 22 '19 11:02 TWiStErRob