Róbert Papp

Results 852 comments of Róbert Papp

As an alternative/considerable rule, I would like to call out the approach we used at https://github.com/detekt/detekt/blob/b616a2f2420743e90cb49939b6284e5a8807a0b9/detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnIfStatementsSpec.kt#L1979-L2010 Focus on the `"else"(3)`-style parts of the code, the builder mechanism definitely needs improving...

Just a quick note to record: if we overhaul the lint test API, and use a builder pattern, then the API could be designed to be extensible to allow all...

I'm baffled this is not linked with #101 yet...

Try to separate/enable the two different verifyNo classes in the API as they're significantly different functionality.

@jrodbx your last comment on https://issuetracker.google.com/issues/288441176 was that this is not fixed, did things change since then?

Note that there are some gif related PRs open, some might be related: https://github.com/cashapp/paparazzi/pulls?q=is%3Apr+is%3Aopen+gif

@anhanh11001 I wouldn't be too worried about this in relation to Paparazzi, because if you use AGP, [`com.android.tools.build:gradle` also depends on `sdk-common` and has the same vulnerabilities](https://mvnrepository.com/artifact/com.android.tools.build/gradle/7.3.1), and you'll be...

Nice, I didn't know about that, and also forgot the fact that mere humans can't select specific components in Google Issuetracker. Anyway, opened https://issuetracker.google.com/issues/262333727.

Not much has changed, see the upstream issue, even in AGP 8 versions they're not updated. Here's my Paparazzi 1.2.0 upgrade branch report: ![Screenshot_20230126-092437](https://user-images.githubusercontent.com/2906988/214801062-d9f3a004-e2e8-47ff-82fb-c1c33913dd6d.png) In [mvnrepository](https://mvnrepository.com/artifact/app.cash.paparazzi/paparazzi/1.2.0) the vulnerabilities are not...